Junio C Hamano <gitster@xxxxxxxxx> wrote: > SZEDER G??bor <szeder@xxxxxxxxxx> writes: > > > On Wed, Oct 07, 2009 at 01:48:51AM -0700, Stephen Boyd wrote: > >> + --dirstat --dirstat= --dirstat-by-file > >> + --dirstat-by-file= --cumulative > > > > I'm a bit puzzled by having both --dirstat and --dirstat=, and > > --dirstat-by-file and --dirstat-by-file=. How do we complete similar > > long options, where an argument and hence the = char is optional? > > A similar example in "git init" completion (--shared vs --shared=) already > exists, no? I'm not sure why this is. It may just be historical accident, completing --shared vs. --shared= is ambiguous so you would need to type out the = anyway before trying to complete a value. IIRC --shared= came about after --shared and its possible we just added the new option and didn't notice the duplicate. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html