Constantine Plotnikov <constantine.plotnikov@xxxxxxxxx> wrote: > See man git-commit (the section "DISCUSSION"), for justification why > UTF-8 should be used. Note that this was already correctly implemented > in ObjectWriter.writeCommit(...) method. But Commit.decode() was not > implemented in the same way for some reason. Commit predates that encoding code in ObjectWriter.writeCommit and it looks like we just forgot to go back and fix it. A very old bug. Since our move to the Eclipse Foundation we really need to follow their IP process, which for non-committers means creating a new bug in their Bugzilla system: https://bugs.eclipse.org/bugs/enter_bug.cgi?product=EGit See also: http://wiki.eclipse.org/EGit/Contributor_Guide#Contributing_Patches > .../tst/org/spearce/jgit/lib/T0003_Basic.java | 3 +++ > .../src/org/spearce/jgit/lib/Commit.java | 18 +++++++----------- > 2 files changed, 10 insertions(+), 11 deletions(-) -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html