Hi, On Tue, 6 Oct 2009, Jens Lehmann wrote: > Johannes Schindelin schrieb: > > Hi, > > > > On Tue, 6 Oct 2009, Junio C Hamano wrote: > > > >> Jens Lehmann <Jens.Lehmann@xxxxxx> writes: > >> > >>>> But I really, really, really want to avoid a fork() in the common case. I > >>>> do have some users on Windows, and I do have a few submodules in that > >>>> project. Having too many fork() calls there would just give Git a bad > >>>> reputation. And it has enough of that, it does not need more. > >>> Me too thinks performance matters here. We do have a repo at my dayjob > >>> with more than a handful of submodules and its main target platform is > >>> windows ... so having that perform nicely is a win for us. > >> Numbers? > >> > >> I'd prefer to avoid kludges that favors unsubstantiated performance > >> argument over correctness. > > > > Well, having worked with msysGit for such a long time, I just _know_ that > > a subprocess costs a substantial amount of time. > > > > But as you don't trust my words, maybe Jens could be so kind as to perform > > some benchmarks? I am short on Git time budget, but I will make a commit > > on my submodule-summary branch that allows to start a subprocess always. > > Sure, will do. Okay, it is there. It is quick and dirty, so you don't even want to look at the commit message. Could you please run something like "time git diff --submodule-summary --all" with and without this patch? Thanks, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html