On Sat, Oct 3, 2009 at 2:40 AM, Jeff King <peff@xxxxxxxx> wrote: > On Sat, Oct 03, 2009 at 12:39:39AM +0000, Erik Faye-Lund wrote: > >> Signed-off-by: Erik Faye-Lund <kusmabite@xxxxxxxxx> > > Why? Given its presence in this series, I can only assume it has to do > with windows portability, but it would be helpful to give a little bit > of the reasoning in the commit message. > > -Peff > Yeah, this is about Windows portability. I'll add something like "This is a patch that enables us to use the run-command API, which is supported on Windows." to the commit-message in the next round. Is that enough? I also guess I should have made a cover letter for this series, making it apparent to reviewers that: - This patch series is about supporting imap-send on Windows - It needs some additional patching to get tunnelling support working on Windows, because we can't exec "/bin/sh" there. Changing it to "c:\\msysgit\\bin\\sh.exe" makes tunneling work for me, but isn't exactly portable across installations. I'll write one up for the next round. -- Erik "kusma" Faye-Lund kusmabite@xxxxxxxxx (+47) 986 59 656 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html