On Mon, Sep 28, 2009 at 11:53:02AM +0200, Johannes Sixt wrote: > Christian Himpel schrieb: > >> The case identified by Christian is certainly important because it is > >> applied to a file whose contents can be anything, and the purpose of the > >> check is to identify the text as an mbox file, whose header section can be > >> only US-ASCII by definition. So, I think it has merit to apply the patch. > > > > Yes. It seems that this is the only place where it is important to match > > just the ASCII printable characters. > > There is another place in git-am.sh where a sed expression with a range > looks at the input file, doesn't it? Isn't it critical, too? > > if test -f "$dotest/rebasing" && > commit=$(sed -e 's/^From \([0-9a-f]*\) .*/\1/' \ > -e q "$dotest/$msgnum") && > test "$(git cat-file -t "$commit")" = commit > then ... It seems to be the line generated from 'git format-patch' that is tested here. It specifies the SHA1 of the commit that is converted into a mbox patch by 'format-patch'. Hence, I don't see it critical here (until someone edits this line by hand). Regards, chressie -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html