On Mon, Sep 28, 2009 at 08:55:19AM +0200, Christian Himpel wrote:
> > Do you happen to know a charset in which this is a problem, just for
> > reference?
>
> No, I don't know any charset with stray ascii-chars. I just listened
> attentively, when I read the part about the mixed alphabet characters in
> the grep(1) manpage.
>
> I did some quick checks just now. It seems the characters (' ' to '~')
> are in any locale, offered by glibc, at the same place.
>
> Maybe, we can just leave the charset as it is and ignore this patch,
> until someone complains.
Thanks for looking into it. My question was more of a "how bad is this,
and should we be fixing these other callsites, too". But I think 0-7 is
probably a pretty safe range in any charset.
Usually with portability issues, I am inclined to say "wait for a
problem", as we try to code to match actual reality instead of
documentation or standards. But in this case, we are unlikely to test
with strange charsets (or even know which strange charsets exist;
checking what's in glibc is reasonable, but I have no idea what else is
out there in other countries), and that the resulting bug would be
subtle and hard to find, it probably makes sense to be a little
defensive.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html