When encryption=tls and smtp cannot connect, git-send-email prints following perl error:
Can't call method "command" on an undefined value at /usr/local/libexec/git-core/git-send-email line 927.
(ithis is when smtp host orport is misspelled, or network is down, and encryption is tls).
We expect some familiar "Cannot connect to SERVER:PORT" message.
Fix it to print normal "smtp can't connect" diagnostics.
--- /usr/local/libexec/git-core/git-send-email.000 2009-09-26 00:10:01.000000000 +0300
+++ /usr/local/libexec/git-core/git-send-email 2009-09-26 00:11:39.000000000 +0300
@@ -922,7 +922,7 @@
$smtp ||= Net::SMTP->new((defined $smtp_server_port)
? "$smtp_server:$smtp_server_port"
: $smtp_server);
- if ($smtp_encryption eq 'tls') {
+ if ($smtp_encryption eq 'tls' && $smtp) {
require Net::SMTP::SSL;
$smtp->command('STARTTLS');
$smtp->response();
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html