Sebastian Schuberth said the following on 23.09.2009 12:03:
From: Frank Li <lznuaa@xxxxxxxxx>
Added the header files dirent.h, unistd.h and utime.h
Add alloca.h, which simply includes malloc.h, which defines alloca
Signed-off-by: Frank Li <lznuaa@xxxxxxxxx>
Signed-off-by: Marius Storm-Olsen <mstormo@xxxxxxxxx>
[...]
create mode 100644 compat/vcbuild/include/sys/utime.h
Have you considered simply including MSVC's sys/utime.h here? From a
first glance, it seems as if it contains all required symbols.
This was a patch which originated from Frank Li's original series.
While we might have been able to simply use the MSVC one, I'm sure
Frank had a reason for overriding it with the small content which you
see in this patch. We'll have to ask Frank about that. We can always
remove it now, if the MSVC version works ok and doesn't introduce any
compiler errors/warnings.
While I appreciate your comments, they are a tad late, as the whole
series is already in master.. :)
See http://repo.or.cz/w/git.git?a=shortlog;h=refs/heads/master
So, give it a try, to see if removing the include override
compat/vcbuild/include/utime.h
doesn't introduce a regression, and send a patch for it.
--
.marius
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html