On Tue, Sep 22, 2009 at 4:05 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > What does this _fix_? The answer here is nothing. But I think the benefit is to a have a pattern, but if it is _not_ desired, I can stop here. > I see v2 and v3 were posted 15 minutes apart. People need to check both > to see what changed, and that also adds to the cost. > > Please slow down. I sent the v3 to fix my mistake: api-builtin.txt to api-parse-options.txt You are right, I have to slow down here. > > I do not mean "please slow down working on your patch, and instead spend > time somewhere else". I mean "please spend more time rre-re-re-reviewing > what you are going to send." If you did so, externally it would look as > if you slowed down ;-). As I said above, I can stop here if this is not a good change. > Among the topics that are cooking in 'next', at least builtin-commit.c and > fast-import.c have changes to overlapping areas this huge patch touches. > At least, exclude the changes to them from this patch, and make patches > separately for them. That would make the cost of conflict resolution > slightly smaller. You need to also check with 'pu', but writing this > response has already made me exceed my git time for today. If the answer above is yes (I can continue), I will separate it in a bunch of commits(patches) and I will check more careful before submit another patch here. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html