On Mon, Sep 21, 2009 at 12:44:05PM -0700, Junio C Hamano wrote: > Craig Taylor <c@xxxxxxxxxxx> writes: > > > Exactly as you describe here, different paths but same goal. > > All binaries follow the DESTDIR path except the perl modules. > > > > To register this as a bug do I need to do more than send this email? > > Do you use NO_PERL_MAKEMAKER in your build? > > If not, we need to summon an expert on ExtUtils::MakeMaker to look into > this issue, but if you do, perhaps you can try this patch and report how > well it works for you. > > --- > perl/Makefile | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/perl/Makefile b/perl/Makefile > index e3dd1a5..4ab21d6 100644 > --- a/perl/Makefile > +++ b/perl/Makefile > @@ -29,11 +29,11 @@ $(makfile): ../GIT-CFLAGS Makefile > '$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \ > echo ' cp private-Error.pm blib/lib/Error.pm' >> $@ > echo install: >> $@ > - echo ' mkdir -p "$(instdir_SQ)"' >> $@ > - echo ' $(RM) "$(instdir_SQ)/Git.pm"; cp Git.pm "$(instdir_SQ)"' >> $@ > - echo ' $(RM) "$(instdir_SQ)/Error.pm"' >> $@ > + echo ' mkdir -p "$$(DESTDIR)$(instdir_SQ)"' >> $@ > + echo ' $(RM) "$$(DESTDIR)$(instdir_SQ)/Git.pm"; cp Git.pm "$$(DESTDIR)$(instdir_SQ)"' >> $@ > + echo ' $(RM) "$$(DESTDIR)$(instdir_SQ)/Error.pm"' >> $@ > '$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \ > - echo ' cp private-Error.pm "$(instdir_SQ)/Error.pm"' >> $@ > + echo ' cp private-Error.pm "$$(DESTDIR)$(instdir_SQ)/Error.pm"' >> $@ > echo instlibdir: >> $@ > echo ' echo $(instdir_SQ)' >> $@ > else ExtUtils::MakeMaker is available and I am using it. The problem seems to be in the generated perl.mak. On line 1652 of my git-1.6.4.3/Makefile $(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install I see that it is passing DESTDIR to the makefile in git-1.6.4.3/perl. However, the DESTDIR variable is not seemingly included in perl/perl.mak for use by the perl/Makefile. It is all absolute paths which I think is the main cause. I have manually manipulated the perl.mak file and install works fine. I'm just updating my build area to 1.6.4.4 and then will try something more permanent. However I am moving outside my knowldge of 'make' now so may request assistance later ;) CraigT -- c^ [c%5e] Never talk about your knowledge, it might make it disappear. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html