Re: [PATCH 04/15] Set _O_BINARY as default fmode for both MinGW and MSVC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Sixt <j.sixt@xxxxxxxxxxxxx> writes:

> Just for the records: The reason why including git-compat-util.h was not
> necessary before 04/15 is that test-genrandom is linked against libgit.a.
> This way the startup code had picked up the definition of _CRT_fmode from
> mingw.c that is initialized to _O_BINARY. After the original 04/15 this
> symbol was not present anymore in libgit.a, and the default (text mode)
> was used. And with this fix, main() is overridden to explicitly set the
> mode of stdout to _O_BINARY.

Beautiful.  I think it is worth mentioning some of the above in the commit
log message.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]