On Tue, Sep 15, 2009 at 4:03 PM, Pat Thoyts <patthoyts@xxxxxxxxxxxxxxxxxxxxx> wrote: >>gitk now includes patches for saving and restoring wm state, however >>because it saves wm geometry when window can still be maximized the >>maximize/restore button becomes useless after restarting gitk (you >>will get a huge displaced window if you try to restore it). This >>patch fixes this issue by storing window geometry in normal state. > I tried this patch on windows and I find that it causes the columns in > the top view to creep each time you restart the application. This is I > think due to the way this patch sets the state to normal before > recording all the settings. This is strange, as I certainly don't see this behaviour now (I'm using gitk in version 1.6.4.3). Actually, I did see that behaviour once, but I believe this was when I ran an unpatched gitk which seemed to record wrong geometry. As soon as I cleared ~/.gitk of those wrong coordinates I haven't seen this behaviour anymore. On the other hand, when I resize columns and then maximize/restore the window repeatedly I see that their sizes change in a strange way (and the smaller restored window they stranger are results) until hitting some sort of equilibrium, then maximize/restore doesn't have effect on their sizes anymore. So maybe there's a bug not in a way my patch restores the window, but in a way window resizes are handled. > I will post an alternative patch that records the normal geometry > whenever it changes instead which seems to work better for me. By all means. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html