Re: [PATCH 08/17] Test for WIN32 instead of __MINGW32_

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano said the following on 14.09.2009 21:31:
Marius Storm-Olsen <mstormo@xxxxxxxxx> writes:

From: Frank Li <lznuaa@xxxxxxxxx>

The code which is conditional on MinGW32 is actually conditional on Windows.
Use the WIN32 symbol, which is defined by the MINGW32 and MSVC environments,
but not by Cygwin.

Signed-off-by: Frank Li <lznuaa@xxxxxxxxx>
Signed-off-by: Marius Storm-Olsen <mstormo@xxxxxxxxx>

The description sounds very sensible; I wish I read this one first, before
wasting time scratching my head while reading 03/17.  Shouldn't that patch
be squashed into this one?

Heh, yeah, I agree. After patch got updated with suggestions from last roll, it clearly makes more sense hear now. I'll update tomorrow. Thanks.

--
.marius
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]