Re: [PATCH] Improve --patch option documentation in git-add

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 13 Sep 2009 17:09:11 +0300
Jari Aalto <jari.aalto@xxxxxxxxx> wrote:

> An update. Thanks,
> Jari
> 
[...]
>  -p::
> --patch::
> -	Similar to Interactive mode but the initial command loop is
> -	bypassed and the 'patch' subcommand is invoked using each of
> -	the specified filepatterns before exiting.
> +	Interactively choose hunks of diff between the index and the
> +	work tree and add them to the index. This gives a change to
> +	review the differences before adding modified contents to the
> +	index.
> +
> +	This effectively runs ``add --interactive``, but bypass the
> +	initial command menu and directly jumps to `patch` subcommand.
> +	See ``Interactive mode'' for details.


Jari,

It's good that you're working to make the documentation better.  To
me though, it seems more difficult to parse this description than the
one offered by Junio in an earlier thread:

        Review the difference between the index and the work tree, and add
        modified contents to the index interactively by choosing which
        patch hunks to use. 

If you don't want to just use that description verbatim, perhaps you'd
consider something closer to yours, such as:

	Interactively review the differences between the index and the
	work tree and choose which hunks to add into the index.

	This effectively runs ``add --interactive``, but bypasses the
	initial command menu and jumps directly to the `patch` subcommand.
	See ``Interactive mode'' for details.

Cheers,
Sean
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]