Dmitry Potapov <dpotapov@xxxxxxxxx> writes: > On Sun, Sep 13, 2009 at 11:52:56AM -0700, Junio C Hamano wrote: >> > + sprintf(fmt_opt, "--format=%s", format); >> > + argv[argc++] = fmt_opt; >> > + argv[argc] = NULL; >> > Either --output or --format option was used before, and this option is > extracted from argv[] by parse_options(). So it should be space for at > least one argument in argv. To my taste, that is a unwarranted (on the borderline) assumption of what parse_options() does, but I'll let it pass with some additional comment to warn readers of the code. Applied. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html