Junio C Hamano <junkio@xxxxxxx> writes: > OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> writes: > >> The current nextfile() jumps to last hunk, but I think this is not >> intention, probably, it's forgetting to add "break;". Right? And this >> patch also adds prevfile(), it jumps to previous hunk. >> >> The following part is just my favorite the key-binds, it doesn't matter. >> >> + bind . <Control-p> "$ctext yview scroll -1 units" >> + bind . <Control-n> "$ctext yview scroll 1 units" >> + bind . <Alt-v> "$ctext yview scroll -1 pages" >> + bind . <Control-v> "$ctext yview scroll 1 pages" >> + bindkey P prevfile >> + bindkey N nextfile >> >> What do you think of this? > > . As a patch e-mail, the initial Hi and trailing Thanks add > additional work for the person who applies patch. Ok. > . I do not have preference on the extra bindings. I do not > speak for Paul, but I suspect he would have liked them in a > separate patch. Ok. I'll send patches. -- OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html