Looking in the vicinity today, I noticed that these fdopen'd streams were never fclosed; technically a leak of both the FILE buffer and the file descriptor. >From aeae4edb1146b107f6a397118db8b0ac06b884d9 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@xxxxxxxxxx> Date: Sat, 12 Sep 2009 11:35:17 +0200 Subject: [PATCH] transport-helper.c: don't leak fdopen'd stream buffers * transport-helper.c (get_helper, fetch_with_fetch, get_refs_list): Call fclose on each just-created FILE* pointer, when done. Signed-off-by: Jim Meyering <meyering@xxxxxxxxxx> --- transport-helper.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/transport-helper.c b/transport-helper.c index f57e84c..0bbd014 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -49,6 +49,7 @@ static struct child_process *get_helper(struct transport *transport) if (!strcmp(buf.buf, "fetch")) data->fetch = 1; } + fclose (file); return data->helper; } @@ -88,6 +89,7 @@ static int fetch_with_fetch(struct transport *transport, if (strbuf_getline(&buf, file, '\n') == EOF) exit(128); /* child died, message supplied already */ } + fclose (file); return 0; } @@ -147,6 +149,7 @@ static struct ref *get_refs_list(struct transport *transport, int for_push) get_sha1_hex(buf.buf, (*tail)->old_sha1); tail = &((*tail)->next); } + fclose (file); strbuf_release(&buf); for (posn = ret; posn; posn = posn->next) -- 1.6.5.rc0.190.g15871 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html