Nicolas Sebrecht <nicolas.s.dev@xxxxxx> writes: > I don't understand your point here. This hunk doesn't allow > --no-no-scissors but add --no-scissors to usage of 'git am', no? > > Do I miss something around $OPTIONS_SPEC? You missed two thirds of the issue and I missed the other one third ;-) As scissors is not marked with ! (see PARSEOPT section in the rev-parse documentation), no-scissors is already available without that hunk, and that is why your patch is unnecessary. Your patch did not mark no-scissors with ! either, so it makes the call to rev-parse --parseopt to process your OPTIONS_SPEC pass --no-no-scissors. However, you did not add --no-no-scissors arm to the case statement that processes rev-parse --parseopt output, so the command as the whole still rejects --no-no-scissors as invalid (this is the last third I missed). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html