Re: [PATCH 4/8] Allow fetch to modify refs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, 3 Sep 2009, Daniel Barkalow wrote:

> +	/**
> +	 * Fetch the objects for the given refs. Note that this gets
> +	 * an array, and should ignore the list structure.

This is not clear at all.  You should rather say "[...] and should not 
look at, or set, the 'next' member of the refs".

> +	 *
> +	 * If the transport did not get hashes for refs in
> +	 * get_refs_list(), it should set the old_sha1 fields in the
> +	 * provided refs now.

Not the "new_sha1"?

> +	 **/
> +	int (*fetch)(struct transport *transport, int refs_nr, struct ref **refs);
> +
> [...]
> +	/** get_refs_list(), fetch(), and push_refs() can keep

The "/**" wants to have a line to itself.

> +	 * resources (such as a connection) reserved for futher
> +	 * use. disconnect() releases these resources.
> +	 **/
>  	int (*disconnect)(struct transport *connection);
>  	char *pack_lockfile;
>  	signed verbose : 2;

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]