On Wed, Sep 02, 2009 at 02:36:47AM -0400, Jeff King wrote: > This patch just explicitly calls disconnect after we are > done with the remote end, which sends a flush packet to > upload-pack and cleanly disconnects, avoiding the error > message. I see you applied this with some extra tests. I should have mentioned in the original cover letter that I considered tests but intentionally did not include them. The problem is that clone forks upload-pack, and then hangs up on it by exiting, and then upload-pack spews the unwanted message. But control has returned to the shell after clone exits, meaning that the message from upload-pack may or may not have gotten there by the time we grep stderr. So I don't think your test will ever incorrectly show a failure, but I believe that it would pass randomly even without the related fix to the code. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html