Nasser Grainawi <nasser@xxxxxxxxxxxxxx> wrote: > Shawn O. Pearce wrote: >> Hmm, maybe a method on Patch is reasonable. > > Going down this route, I'd add a few things to Patch. > patchId would be a private field (of type ObjectId?) > getPatchId would be a public method that returns patchId > and then likely a private method (computePatchId?) that actually > generates the patchId Sure, but getPatchId can compute it on demand on the first call, and anyone who modifies the Patch would just need to clear out the cached patchId value so the next call (if it ever comes) to getPatchId would force it to recompute. Most users of Patch won't want the patchId, so there is no reason to compute it. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html