On Wed, Sep 02, 2009 at 09:09:19AM +0200, Sverre Rabbelier wrote: > On Wed, Sep 2, 2009 at 08:36, Jeff King<peff@xxxxxxxx> wrote: > > As you can see from the commit message, I did a little extra hunting to > > make sure we are not going to impact any other code paths, and I am > > pretty sure we are fine. > > Thank you for fixing my mistake :). You're welcome, though I am not sure it is your mistake. Arguably this is something we should have been doing all along. The point of abstracting transports was that we didn't need to know their details at the outer layer, but in this case we were relying on the fact that no transports (until empty-clone-over-git) needed an explicit transport_disconnect to cleanly hang up on the other end. So think of it as you exposing a long-standing bug. ;) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html