On Wed, Sep 02, 2009 at 12:33:52AM -0400, Daniel Barkalow wrote: > > The patch below seems to work for me, but I'm a little concerned how it > > might impact other transports. > > Does putting a "transport_disconnect(transport);" after the > "transport_unlock_pack(transport);" in builtin-clone.c also work for you? > I think that's a cleaner solution, and should future-proof it in case we > have a future transport that both doesn't disconnect itself after a fetch > and gives an error message if the connection is dropped suddenly. > > It's kind of just an accident that the only transport that cares about > disconnect very much doesn't care if you've fetched after getting the > refs. It does work, and I think that is a much saner solution for the reasons you mention. Thanks. Do you want to write it up and submit it, or should I? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html