Junio C Hamano wrote: > Jim Meyering <jim@xxxxxxxxxxxx> writes: >> Junio C Hamano wrote: >> ... >>> Subject: [PATCH] diff --quiet: special case "ignore whitespace" options >>> ... >>> Change the semantics of --ignore-whitespace* options to mean more than >>> "omit showing the difference in text". When these options are used, the >>> internal "quick" optimization is turned off, and the status reported with >>> the --exit-code option will now match if any the textual diff output is >>> actually produced. >>> >>> Also rename the internal option "QUIET" to "QUICK" to better reflect what >>> its true purpose is. >> >> Thanks again. >> If there's anything I can to do help (add a test?), let me know. > > The change has been cooking in 'next' and hopefully be in 1.7.0. I think > the updated series adds its own test script, too. > > Using it in every day scenario, and reporting any breakage you notice > before 1.7.0 happens, would be greatly appreciated. Oh! I am using next (will test!), and even searched log summary output, but obviously my search was too cursory or just inaccurate. I glanced through it and it looks fine (of course!). I spotted one typo, and suggest a second change that's barely worth mentioning, both in comments: diff --git a/diff.c b/diff.c index 91d6ea2..24bd3fc 100644 --- a/diff.c +++ b/diff.c @@ -2382,7 +2382,7 @@ int diff_setup_done(struct diff_options *options) * Most of the time we can say "there are changes" * only by checking if there are changed paths, but * --ignore-whitespace* options force us to look - * inside contets. + * inside contents. */ if (DIFF_XDL_TST(options, IGNORE_WHITESPACE) || @@ -3346,7 +3346,7 @@ free_queue: fclose(options->file); /* - * Report the contents level differences with HAS_CHANGES; + * Report the content-level differences with HAS_CHANGES; * diff_addremove/diff_change does not set the bit when * DIFF_FROM_CONTENTS is in effect (e.g. with -w). */ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html