Re: [PATCH 08/14] Test for WIN32 instead of __MINGW32_

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 08/14] Test for WIN32 instead of __MINGW32_
From: Paolo Bonzini <bonzini@xxxxxxx>
Date: Fri, 28 Aug 2009 10:15:10 +0200
Cc: Johannes.Schindelin@xxxxxx, msysgit@xxxxxxxxxxxxxxxx, git@xxxxxxxxxxxxxxx, lznuaa@xxxxxxxxx
In-reply-to: <1e623b19b2df001919c83418fef89ef04d7b8dfe.1250860247.git.mstormo@xxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3

Since you are doing this, you may as well change patch 3 from

+#if (defined(__MINGW32__) && defined(__GNUC__) && __GNUC__ < 4) ||defined(_MSC_VER)


to this:

#if defined WIN32 && (!defined (__GNUC__) || __GNUC__ < 4))

Paolo
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

References:
- [RFC/PATCH 00/14] Build git with MSVC
  - From: Marius Storm-Olsen
- [PATCH 01/14] Fix non-constant array creation
  - From: Marius Storm-Olsen
- [PATCH 02/14] Avoid declaration after statement
  - From: Marius Storm-Olsen
- [PATCH 03/14] Define SNPRINTF_SIZE_CORR=1 for Microsoft Visual C++
  - From: Marius Storm-Olsen
- [PATCH 04/14] Add define guards to compat/win32.h
  - From: Marius Storm-Olsen
- [PATCH 05/14] Change regerror() declaration from K&R style to ANSI C (C89)
  - From: Marius Storm-Olsen
- [PATCH 06/14] mingw.c: Use the O_BINARY flag to open files
  - From: Marius Storm-Olsen
- [PATCH 07/14] Fix __stdcall/WINAPI placement and function prototype
  - From: Marius Storm-Olsen
- [PATCH 08/14] Test for WIN32 instead of __MINGW32_
  - From: Marius Storm-Olsen

Prev by Date: Re: git-svn intermittent issues with absent_file
Next by Date: Re: Using git to track my PhD thesis, couple of questions
Previous by thread: Re: [PATCH 09/14] Avoid including windows.h in winansi.c for MSVC build
Next by thread: Re: [msysGit] [PATCH 07/14] Fix __stdcall/WINAPI placement and function prototype
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]