Re: [PATCHv4 08/12] Teach the notes lookup code to parse notes trees with various fanout schemes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> On Fri, Aug 28, 2009 at 01:03:05AM +0200, Johan Herland wrote:
>
>> Agreed. I'm starting to come around to the idea of storing them in subtrees 
>> based on commit dates. For one, you don't have multiple notes for one commit 
>> in the same notes tree. Also, the common-case access pattern seems tempting.
>> 
>> Dscho: Were there other problems with the date-based approach other than not 
>> supporting notes on trees and blobs?
>> 
>> If not, I'll start preparing another series with the date-based approach.
>
> Would you ever want to load a note for a commit when you did not have
> that commit present (in which case you would not know its date)?

You cannot "git show" nor "git checkout" it, nor have reached it via "git
bisect".  How did you get interested in the commit in the first place?

What is the reason you are not fetching the commit after you somehow got
interested in the commit?

Here is one possible scenario I can think of.  The notes tree is published
and distributed more widely than the project's main source.  You fetch and
usually follow notes tree (which would probably be more lightweight) but
not the source.  Perhaps your bug tracking system is based on notes, and
the project is throwing all the bugs in one such notes tree.  You are a
bug tracking person, and you are following the notes tree closely, but are
only following the 'master' branch but not 'next' nor 'pu'.

And you somehow browse through the 'notes' tree, and learn that a note
refers to an interesting commit.  But the commit the note applies to is
not yet in 'master' so you do not have it.  Even though you would want to
fetch 'next' and 'pu', you are having connection problem and you cannot
fetch the source until your ISP gets back online tomorrow morning.

Nah, that's not a plausible scenario---at that point you already have read
the note.

So, how?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]