Dear diary, on Sat, Sep 16, 2006 at 05:10:36PM CEST, I got a letter where Jim Meyering <jim@xxxxxxxxxxxx> said that... > Jonas Fonseca <fonseca@xxxxxxx> wrote: > > Jim Meyering <jim@xxxxxxxxxxxx> wrote Thu, Aug 24, 2006: > >> I tried cg-commit with a commit hook, but the hook never ran. > >> The problem was a typo: > >> > >> Fix a typo that would inhibit running the post-commit script: > >> s/commit-post/post-commit/. > > > > If I remember correctly, historically, the commit-post existed before > > the post-commit appeared. You can see that it is documented in the man > > page so it is not a typo. > > > > However, this should certainly be updated, but I think a better fix > > would be to transitionally warn the user about the existence of the > > commit-post hook before using it in favour of post-commit. > > How about this? > Check for both and if there's exactly one, use that. > If it's the old one, give a diagnostic suggesting to rename it. > If both exist, execute neither, give a diagnostic and fail. > > If you like this, I'll prepare a patch. That would be awesome. :-) Thanks in advance, -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ #!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj $/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1 lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/) - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html