Thell Fowler <git@xxxxxxxxxxxxx> writes: > It passed every test I threw at it, although it seemed to be a tad bit > slower than the previous revision on my sample data so I ran the following > command several times for both the previous and current version: > > time for i in {1..10}; do ./t4015-diff-whitespace.sh>/dev/null && > ./t4015-diff-trailing-whitespace.sh >/dev/null; done > > And these results are fairly average on what I saw: > > Previous version: > real 2m32.669s > user 0m44.051s > sys 1m34.702s > > > Current version: > real 2m56.818s > user 0m47.671s > sys 1m46.723s Do you mean by "previous version" the one that was broken, or the one I sent as a "how about" patch? Here are the numbers I am getting: $ /usr/bin/time sh -c 'for i in 1 2 3 4 5 6 7 8 9 0; do ./t4015-diff-whitespace.sh; done' >/dev/null ---------------- 1.99user 3.65system 0:05.10elapsed 110%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+12560outputs (0major+1288675minor)pagefaults 0swaps 1.86user 3.66system 0:05.04elapsed 109%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+12560outputs (0major+1288618minor)pagefaults 0swaps 1.76user 3.87system 0:05.02elapsed 112%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+12560outputs (0major+1288973minor)pagefaults 0swaps ---------------- 1.81user 3.86system 0:05.08elapsed 111%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+12560outputs (0major+1288836minor)pagefaults 0swaps 1.76user 3.87system 0:04.95elapsed 113%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+12560outputs (0major+1288880minor)pagefaults 0swaps 1.81user 3.88system 0:05.04elapsed 112%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+12560outputs (0major+1288530minor)pagefaults 0swaps ---------------- One set is with patch and one set is the patch reverted. I cannot quite remember which one is which ;-) but the difference is within the noise for me. I have to revisit this sometime after getting a long rest. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html