Re: hitting home directory's parent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 22, 2009 at 11:20:39PM +0700, Nguyen Thai Ngoc Duy wrote:

> > I did read a bit farther in the manual and initialized a new repository.
> > Issuing "git --help" once inside that new repository works.  Requiring
> > the --help command to be called from inside a repository, or even that
> > it's looking for a repository at all, seems unwise.  All it should do is
> > display the usage information and exit.
> 
> For simple things like --help, I agree Git should not do extra work
> such as searching for Git repository, which is the cause. That was on
> Jeff's plan IIRC.

Without looking, I would not be surprised if it is a side effect of
git trying to look up help-related config. So I don't think it is a
problem exactly that it checks to see if it is in a repo (which would
impact config lookup), but that inability to find a repo is a hard
error.

Probably it is calling "setup_git_directory_gently" and ignoring an
error return, but there is a die() inside that function. The bug
then is that the _gently form is calling die().

As for fixing the setup code, I am sadly way behind on my git queue and
not likely to catch up to this anytime soon. So if anybody feels like
taking a stab at it, that would be very welcome.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]