[With correct CC list. Sorry for the resend Robin]
On Thu, Aug 20, 2009 at 18:35, Robin
Rosenberg<robin.rosenberg.lists@xxxxxxxxxx> wrote:
> onsdag 19 augusti 2009 15:18:11 skrev Jonas Fonseca <fonseca@xxxxxxx>:
>> Fixes breakage in the RepositoryCacheTest when running tests using:
>>
>> mvn -f ./jgit-maven/jgit/pom.xml test
>> [...]
>> @@ -217,7 +217,7 @@ public void setUp() throws Exception {
>> trash = new File(trashParent,"trash"+System.currentTimeMillis()+"."+(testcount++));
>> - trash_git = new File(trash, ".git");
>> + trash_git = new File(trash, ".git").getCanonicalFile();
>> @@ -307,7 +307,7 @@ protected Repository createNewEmptyRepo() throws IOException {
>> protected Repository createNewEmptyRepo(boolean bare) throws IOException {
>> final File newTestRepo = new File(trashParent, "new"
>> + System.currentTimeMillis() + "." + (testcount++)
>> - + (bare ? "" : "/") + ".git");
>> + + (bare ? "" : "/") + ".git").getCanonicalFile();
>
> We use getCanonicalFile here and Repository.gitDir is initialized with getAbsoluteDir.
BTW, a simpler fix would be to initialize trashParent to a canonical
path, which might be less intrusive.
> Does this work on all platforms?
I have only tested on Linux.
> Seems linux normalized things when you do things like, but I'm not sure that happens everywhere.
If you think it is a problem, let's drop the patch. It just seemed
like a simple way to increase robustness.
--
Jonas Fonseca
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html