Christian Couder <chriscool@xxxxxxxxxxxxx> writes:
> From: Stephan Beyer <s-beyer@xxxxxxx>
>
> This commit is made of code from the sequencer GSoC project:
>
> git://repo.or.cz/git/sbeyer.git
>
> (commit 5a78908b70ceb5a4ea9fd4b82f07ceba1f019079)
>
> The goal of this commit is to abstract out pick functionnality
> into a new pick() function made of code from "builtin-revert.c".
>
> The new pick() function is in a new "pick.c" file with an
> associated "pick.h".
Is it pick() or pick_commit()?
By the way, this comment applies to other messages in the series, but do
these original commits by Stephan lack any meaningful messages? I would
actually have expected to see a commit log message that looks more like:
From: Stephan Beyer <...>
Meaningful log message Stephan describes what this commit does in
sufficient detail, perhaps with clarification and rewording by
Christian.
Second and subsequent paragraph to explain it as necessary.
[cc: this is based on 5a78908b70ceb5a4ea9fd4b82f07ceba1f019079
from Stephan's git://repo.or.cz/git/sbeyer.git]
Signed-off-by: ...
The point is that the "origin info" would be a side-note, not the first
and the most important thing in the message.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html