Hi, On Tue, 18 Aug 2009, Marius Storm-Olsen wrote: > Johannes Schindelin said the following on 18.08.2009 16:11: > > > On Tue, 18 Aug 2009, Marius Storm-Olsen wrote: > > > > > diff --git a/Makefile b/Makefile > > > +ifneq (,$(findstring Microsoft Visual Studio, $(INCLUDE))) > ... > > > +else > > > ifneq (,$(findstring MINGW,$(uname_S))) > > > pathsep = ; > > > NO_PREAD = YesPlease > > > > This means that gcc is never used when Visual C++ is available? Hmm. > > Yes it does :) As you know, I do not own a Windows computer. On the Windows computer I am allowed to use sometimes to test Git and my day-time project, the Express edition was installed, but it was never registered, so it is not usable, and I would not want to use it anyway. So this change would break my setup. > I was actually going to replace it with a USE_MSVC variable check > instead though, so you'd rather do 'make USE_MSVC=1' That's much nicer, especially since you can put that into config.mak. > > > diff --git a/compat/msvc.h b/compat/msvc.h > > > index 6071565..a9d5f7f 100644 > > > --- a/compat/msvc.h > > > +++ b/compat/msvc.h > > > @@ -10,50 +10,120 @@ > > > > > > /*Configuration*/ > > > > > > +#ifndef NO_PREAD > > > #define NO_PREAD > > > +#endif > > > > Why? You now have the stuff in two places. If you want to keep them > > in compat/msvc.h to be able to generate .vcproj files, I'd rather not > > have them duplicated in the Makefile. > > The changes to the msvc.h where added just keep Frank's vcproj project > working. I would have just nuked all that stuff in the msvc.h since the > Makefile would just provide it for me anyways.. So maybe you and Frank (and Pau) hash out what you want? Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html