Re: [PATCH 3/3] stash: reject stash name starting with a dash.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 18, 2009 at 04:45:40PM -0700, Junio C Hamano wrote:

> > Should this actually be "git stash save --invalid-option", since it is
> > really testing the actual save option parsing, and not the behavior to
> > automatically push options to "git stash save"?
> 
> It would be ideal if
> 
> 	git stash save --invalid-option
> 
> failed, while
> 
> 	git stash --invalid-option should be trapped
> 
> and/or
> 
> 	git stash "--invalid-option should be trapped"
> 
> are accepted as valid quickie ways to name a WIP stash before attending to
> an unrelated emergency.

I thought that was the exact DWIM that was rejected previously so that
you don't accidentally make commits with "git stash llist" or "git stash
--almost-a-valid-optio".

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]