Re: [PATCH] graph API: fix bug in graph_is_interesting()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Adam Simpkins <simpkins@xxxxxxxxxxxx> writes:

> -	return (commit->object.flags & (UNINTERESTING | TREESAME)) ? 0 : 1;
> +	return simplify_commit(graph->revs, commit) == commit_show;

If you do this after revision.c finished the traversal (e.g. "limited"
case), I think it should be Ok.

But calling simplify_commit() while the traversal is still in progress is
asking for trouble.  I do not recall the details anymore but when I tried
to make the "simplify-merges" algorithm incremental, I had seen funny
breakage caused by calling simplify_commit() twice on the same commit.

I suspect that this change will break the primary traversal.


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]