Hi, On Tue, 18 Aug 2009, Jeff King wrote: > On Tue, Aug 18, 2009 at 03:01:52PM +0200, Matthieu Moy wrote: > > > Hmm, googling a bit, I just noticed that there's already something in > > pu: > > ea41cfc4f (Make 'git stash -k' a short form for 'git stash save --keep-index') > > which also does the trick, while adding a -k alias for --keep-index. > > > > [...] > > > > Mine has at least two advantages: > > > > * It won't require changing the code again when new options are added > > to 'git stash save'. > > > > * It works with 'git stash -k -q' for example, while the other > > proposal checks that $# == 1, which won't work if there are more > > than one option. > > I think yours is nicer, especially as we have just added the > '-p|--patch' option, as well. With what is there now, you can do "git > stash -p", but not "git stash -p -k". But it is sloppy, in that it blindly accepts options that might be valid for several subcommands, not just "save". That was the reason I did not implement it this way. But we do not have such ambiguous options yet. Or do we? Look at what "list" accepts! So please register my objection. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html