Junio C Hamano said the following on 18.08.2009 18:51:
Marius Storm-Olsen <mstormo@xxxxxxxxx> writes:
Marius Storm-Olsen <mstormo@xxxxxxxxx> writes:
+ARFLAGS = rcs\ # whitespace intentional
+COMPFLAG = -c
+COBJFLAG = -o\ # whitespace intended
+LOBJFLAG = -o\ # whitespace intended
...
+ifneq (,$(findstring Microsoft Visual Studio, $(INCLUDE)))
+ CC = cl
+ COBJFLAG = -Fo
+ LOBJFLAG = -OUT:
+ CFLAGS =
git.o: git.c common-cmds.h GIT-CFLAGS
...
- $(ALL_CFLAGS) -c $(filter %.c,$^)
+ $(ALL_CFLAGS) $(COMPFLAG) $(COBJFLAG)git.o $(filter %.c,$^)
Since use of make implies use of shell, this makes me wonder if it would
make sense to go one step further by giving msvc users a thin shell
wrapper mcvc-cc that turns bog-standard cc command line into whatever cl
uses.
That, of course, is also a feasible option :)
However, there are still things you wouldn't want to pass on to this
script, for example, we don't pass on all the CFLAGS to the linker on
Windows.
The "whitespace intended" in the patch are quite nasty though..
--
.marius
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html