Re: [PATCH] block-sha1: make the size member first in the context struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 17 Aug 2009, Nicolas Pitre wrote:

> This is a 64-bit value, hence having it first provides a better 
> alignment.
> 
> Signed-off-by: Nicolas Pitre <nico@xxxxxxx>
> 
> diff --git a/block-sha1/sha1.h b/block-sha1/sha1.h
> index 6ff59b2..b864df6 100644
> --- a/block-sha1/sha1.h
> +++ b/block-sha1/sha1.h
> @@ -7,9 +7,9 @@
>   */
>  
>  typedef struct {
> +	unsigned long long size;
>  	unsigned int H[5];
>  	unsigned int W[16];
> -	unsigned long long size;
>  } blk_SHA_CTX;

By the reasoning suggested in the commit message, should H[5] not go to 
the end?

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]