Karthik R <karthikr@xxxxxxxxxxx> writes:
> +# If GIT_SSH is set, also set SVN_SSH...
> +$ENV{SVN_SSH} = $ENV{GIT_SSH} if defined $ENV{GIT_SSH};
> +# ... and escape \s in shell-variable on Windows
> +if ($^O eq 'MSWin32' || $^O eq 'msys') {
> + $ENV{SVN_SSH} =~ s/\\/\\\\/g if defined $ENV{SVN_SSH};
> +}
> +
Two questions.
- What if a user has SVN_SSH exported _and_ wants to use a different one
from the one s/he uses for git? Naturally such a user would set both
environment variables and differently, but this seems to override the
value in SVN_SSH;
- Can a user have SVN_SSH exported, on MSWin32 or msys, and use svn
outside git? If so, what does the value of SVN_SSH look like? Does it
typically have necessary doubling of backslashes already?
What I am getting at is, if the patch should look something like this
instead:
if (! exists $ENV{SVN_SSH}) {
if (exists $ENV{GIT_SSH}) {
$ENV{SVN_SSH} = $ENV{GIT_SSH};
if ($^O eq 'MSWin32' || $^O eq 'msys') {
$ENV{SVN_SSH} =~ s/\\/\\\\/g;
}
}
}
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html