Hi, On Tue, 18 Aug 2009, Frank Li wrote: > Signed-off-by: Frank Li <lznuaa@xxxxxxxxx> How about this instead? Add missing git-compat-util.h to regex.c and fnmatch.c This will be needed to compile with Microsoft Visual C++. > diff --git a/compat/fnmatch/fnmatch.c b/compat/fnmatch/fnmatch.c > index 14feac7..5cbd49c 100644 > --- a/compat/fnmatch/fnmatch.c > +++ b/compat/fnmatch/fnmatch.c > @@ -16,6 +16,10 @@ > write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, > Boston, MA 02111-1307, USA. */ > > +#ifdef _MSC_VER > +#include "git-compat-util.h" > +#endif > + Why not leave those #ifdef guards? Either they don't hurt, or they will hurt Microsoft Visual C++, too. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html