Hi, On Mon, 17 Aug 2009, Johannes Sixt wrote: > Johannes Schindelin schrieb: > > On Mon, 17 Aug 2009, skillzero@xxxxxxxxx wrote: > >> On Mon, Aug 17, 2009 at 1:17 AM, Nguyen Thai Ngoc Duy<pclouds@xxxxxxxxx> wrote: > >>> On Mon, Aug 17, 2009 at 1:09 PM, <skillzero@xxxxxxxxx> wrote: > >>>> 1. Have people decided whether it should be on by default if you have > >>>> a .git/info/sparse file? I'd definitely like it to be on by > >>>> default. When I first tried it, I didn't realize I had to use > >>>> --sparse to git checkout to get it to use the sparse rules. The > >>>> same goes for a merge I did that happened to have a file in the > >>>> excluded area (it included it because I didn't use --sparse to git > >>>> merge). > >>> I tend to make it enabled by default too. I have made it stricter to > >>> trigger reading sparse in unpack_trees() -- only do it when > >>> unpack_opts.update is TRUE. This should make it safer to be enabled by > >>> default. > >> Other than it being new and not-widely-tested code, is there any > >> additional risk to having it enabled by default if there are no sparse > >> patterns defined? > > > > I think that in and of itself is reason enough to turn off the feature > > when .git/info/sparse is not present. > > I might have missed something: Would there be any observable difference > between whether .git/info/sparse is absent and whether it is empty? There _should_ not be an _observable_ difference. > If not, what do you mean by "turn the feature off"? There is a global variable which triggers the code path that looks through the sparse patterns. I'd like this variable to be "off" by default. > >> It would be nice if .git/info/sparse is there by default (like > >> .git/info/exclude) with some commented out instructions (also like > >> .git/info/exclude). > > > > I'm not a fan of this idea. > > For any particular reason? First, it is an experimental feature. I'd hate it if people who do not want to use the sparse feature are affected. Second, even if the sparse pattern list is empty, an additional call to the function that matches files against the pattern would take additional runtime. If I had time, I could think of a third reason. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html