Hi, On Mon, 17 Aug 2009, Johannes Sixt wrote: > Pat Thoyts schrieb: > > 2009/8/17 Frank Li <lznuaa@xxxxxxxxx>: > >> I am tring to clear VC build patch. > >> > >> I found __stdcall position break MSVC build. > >> > >> static __stdcall unsigned run_thread(void *data) > >> > >> MSVC require __stdcall should be between return type and function > >> name. like static unsigned __stdcall run_thread(void *data) > >> > >> I think msys gcc should support MSVC format. I think that it does. But it is _your_ duty to check. > >> Should I directly change to MSVC format or add _MSC_VER marcro like > >> > >> #if defined(__MINGW32__) > >> static __stdcall unsigned run_thread(void *data) > >> #elif defined(_MSC_VER) /*MSVC must put __stdcall between return value > >> and function*/ > >> static unsigned __stdcall run_thread(void *data) > >> #endif Noooo! NO _MSC_VER crap in mingw.c. Really. I am able to repeat that as often as you want me, but I'd prefer not to. > > The win32 api prototype used for thread entry functions is declared as > > a DWORD (WINAPI *LPTHREAD_START_ROUTINE)(LPVOID) type in the mingw > > headers and WINAPI as #define WINAPI __stdcall. This is true for the > > MSVC headers as well. So gcc and msvc are happy using the same > > definition for such a function and just "static unsigned long WINAPI > > run_thread(void *)" might well be sensible. > > Change the code to > > static unsigned __stdcall run_thread(void *data) > > The documentation explictly says: "The routine at start_address passed to > _beginthreadex must use the __stdcall calling convention...". So __stdcall > it is. I could not agree more. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html