Re: [PATCH] git stash: Give friendlier errors when there is nothing to apply

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ori Avtalion <ori@xxxxxxxxxxxxx> writes:

> The change makes sure a stash (given or default) exists before
> checking if the working tree is dirty.
>
> If the default stash is requested, the old message was scary and
> included a 'fatal' error from rev-parse:
>      fatal: Needed a single revision
>      : no valid stashed state found
>
> It is replaced with a friendlier 'Nothing to apply' error, similar to
> 'git stash branch'.
>
> If a specific stash is specified, the 'Needed a single revision' errors
> from rev-parse are suppressed.
>
> Signed-off-by: Ori Avtalion <ori@xxxxxxxxxxxxx>
> Acked-by: Thomas Rast <trast@xxxxxxxxxxxxxxx>

I do not see anything that might break existing usage of the command.
Comments?

A tangent; we might want an analogue to "shortlog -s -n" but based on
"blame".
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]