On 2009-08-14 09:26:06 +0200, Erik Sandberg wrote: > Wouldn't it be better to only use the write() workaround when > sys.version indicates that the Python bug may be present, and use > communicate() properly otherwise? In my opinion: no. The workaround has no negative effect (since we know that git is well-behaved). Making it conditional would only make the code more complex, without gaining us anything. -- Karl Wiberg, Virtutech -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html