onsdag 12 augusti 2009 16:20:49 skrev "Shawn O. Pearce" <spearce@xxxxxxxxxxx>: > Alex Blewitt <alex.blewitt@xxxxxxxxx> wrote: > > On 10 Aug 2009, at 21:59, "Shawn O." <spearce@xxxxxxxxxxx> wrote: > >> > >>>> ./org/spearce/jgit/revwalk/RevTag.java:206: getName() in > >>>> org.spearce.jgit.revwalk.RevTag cannot override getName() in > >>>> org.spearce.jgit.lib.AnyObjectId; overridden method is final > >> > >> I can't apply this patch because getName() on RevTag is already > >> defined with a different meaning. :-( > > > > That sounds dangerous. We now have a .name() and a .getName() with > > different semantics. Can we not change the RevTag method name to > > something else so that we dont have an inconsistency? > > Good point. We didn't think that RevTag.getName method through > very well. Rename it to getTagName() ? Ok with me. -- robin -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html