On Tue, 11 Aug 2009, Johan Herland wrote:
> @@ -293,6 +301,16 @@ int transport_helper_init(struct transport *transport)
> data->name = xstrndup(transport->url, eom - transport->url);
> }
>
> + strbuf_addf(&buf, "remote-%s", data->name);
> + cmd = strbuf_detach(&buf, NULL);
> + if (!is_git_command_or_alias(cmd)) {
> + warning("Could not find remote helper command \"git %s\". Assuming native remote.", cmd);
Won't this give you a warning for:
url = master.kernel.org:something
of 'Could not find (...) "git remote-master.kernel.org" (...)'? That
would be certain to upset some people. I think we can assume that people's
scheme parts of their URLs that are actually URLs don't contain '.', and
that people with:
url = master:something
will append their domains if the warning gets annoying.
-Daniel
*This .sig left intentionally blank*
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html