Jeff Lasslett <jeff.lasslett@xxxxxxxxx> writes: > In new_http_object_request(), check ftruncate() call return value and > handle possible errors. Remove possible leak of mem pointed to by url. Are you assuming that everybody is running libcurl 7.17.0 or later? Before that version strings given to easy_setopt() were not copied and you needed to keep them around. I think freeing url is fine but you would probably need to then give freq->url to easy_setopt(CURLOPT_URL) if you wanted to do so. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html