On Thu, Aug 6, 2009 at 1:53 PM, Tim Harper<timcharper@xxxxxxxxx> wrote:
> When running the command 'git branch --contains efabdfb' on a repository that doesn't yet have efabdfb, git reports: "malformed object name efabdfb". To the uninitiated, this makes little sense (as far as they are concerned, efabdfb is perfectly formed).
>
> This commit changes the message to "malformed object name or no such commit: efabdfb"
> ---
> parse-options.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/parse-options.c b/parse-options.c
> index 3b71fbb..95eb1c4 100644
> --- a/parse-options.c
> +++ b/parse-options.c
> @@ -615,7 +615,7 @@ int parse_opt_with_commit(const struct option *opt, const char *arg, int unset)
> if (!arg)
> return -1;
> if (get_sha1(arg, sha1))
> - return error("malformed object name %s", arg);
> + return error("malformed object name or no such commit: %s", arg);
> commit = lookup_commit_reference(sha1);
> if (!commit)
> return error("no such commit %s", arg);
> --
> 1.6.4
>
>
Does nobody think this is a good idea?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html