Re: [PATCH] svn: Add && to t9107-git-svn-migrarte.sh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Adam Brewster <adambrewster@xxxxxxxxx> wrote:
> It was probably intended for the test to fail unless all of the
> commands succeed.

I think you've uncovered some major breakage in this test that never got
noticed until now.  I'll try to take a harder look tonight or this
weekend.

Fortunately, this functionality is rarely needed these days :)
Thanks for the heads up!

> ---
>  t/t9107-git-svn-migrate.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/t/t9107-git-svn-migrate.sh b/t/t9107-git-svn-migrate.sh
> index 3a9e077..145a367 100755
> --- a/t/t9107-git-svn-migrate.sh
> +++ b/t/t9107-git-svn-migrate.sh
> @@ -93,7 +93,7 @@ test_expect_success 'migrate --minimize on old inited layout' '
>  	grep "^branches/b:refs/remotes/b$" fetch.out &&
>  	grep "^tags/0\.1:refs/remotes/tags/0\.1$" fetch.out &&
>  	grep "^tags/0\.2:refs/remotes/tags/0\.2$" fetch.out &&
> -	grep "^tags/0\.3:refs/remotes/tags/0\.3$" fetch.out
> +	grep "^tags/0\.3:refs/remotes/tags/0\.3$" fetch.out &&
>  	grep "^:refs/${remotes_git_svn}" fetch.out
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]