On Thu, 21 Sep 2006, Junio C Hamano wrote: > > Ok, so I did these and the result is a 4-patch series. Looks good to me. I would have combined 2/3, since the bulk of them is the calling conversion change, and they both add a new argument to the same function, so combining them would make just one patch that isn't even noticeably larger than either of the two originals, but that's just a small nitpick. Having callback data is clearly good, and the "flags" may end up being useful for other things in the future too (ie if we add attributes to branches, we could at some point have "hidden" and "read-only" etc flags) Linus - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html