Re: Message from git reset: confusing?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matthieu Moy <Matthieu.Moy@xxxxxxx> writes:

> This is my biggest issue, indeed. Actually, several things bother me
> (by decreasing annoyance):
>
> 1) It looks like an error message, and user can think git reset
> failed.
>
> 2) It's inconsistant with the usual status display. I'd prefer an
> output like "git diff --name-only" or "git status".
> ...
> So, let's address 1) and 2) only.
>
> Any opinion? Am I going in the right direction?

I think the approach is sane.  I didn't check if the unconditional 

	printf("Unstaged changes after reset:\n");

needs to be protected, or at that point we already know we will talk about
one or more paths (either needs update or needs merge).
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]